Skip to content

[Bookings] Remove dash from empty state text #16403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2025
Merged

[Bookings] Remove dash from empty state text #16403

merged 1 commit into from
Nov 27, 2025

Conversation

@RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Nov 26, 2025 •
edited
Loading

WOOMOB-1759

Description

Removed the dash from empty state localized string. Found only 1 occurrence.

Test Steps

  • Use CIAB store with bookings
  • Go to Bookings tab
  • Enter search bar and input some nonsense to have 0 search results.
  • Make sure the empty state test is correct and doesn't have dashes.

Screenshots

Before After
Снимок экрана 2025-11-26 в 12 11 03 Снимок экрана 2025-11-26 в 12 09 40
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@RafaelKayumov RafaelKayumov added this to the 23.8 milestone Nov 26, 2025
@RafaelKayumov RafaelKayumov added the type: task An internally driven task. label Nov 26, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 26, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.8. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 26, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16403-6268bc4
Version23.7
Bundle IDcom.automattic.alpha.woocommerce
Commit6268bc4
Installation URL0pv9vjop85u8o
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@adborbas adborbas self-assigned this Nov 26, 2025
adborbas
adborbas approved these changes Nov 26, 2025
View reviewed changes
Copy link
Contributor

@adborbas adborbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Image

@RafaelKayumov RafaelKayumov merged commit de1bd6a into trunk Nov 27, 2025
18 of 19 checks passed
@RafaelKayumov RafaelKayumov deleted the WOOMOB-1759-remove-dash-from-empty-state-text branch November 27, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adborbas adborbas adborbas approved these changes

@itsmeichigo itsmeichigo Awaiting requested review from itsmeichigo

Assignees

@adborbas adborbas

Labels

type: task An internally driven task.

Projects

None yet

Milestone

23.8 ❄️

Development

Successfully merging this pull request may close these issues.

5 participants

@RafaelKayumov @dangermattic @wpmobilebot @adborbas